Skip to content

feat: custom icon for clear in seachbar#965

Merged
ferrannp merged 1 commit intocallstack:masterfrom
raajnadar:master
Apr 15, 2019
Merged

feat: custom icon for clear in seachbar#965
ferrannp merged 1 commit intocallstack:masterfrom
raajnadar:master

Conversation

@raajnadar
Copy link
Copy Markdown
Collaborator

@raajnadar raajnadar commented Mar 30, 2019

Motivation

Closes #707

Test plan

<Searchbar
      placeholder="Search"
      value="Test"
      clearIcon="custom-icon-name"
/>

@raajnadar raajnadar requested a review from Trancever March 30, 2019 15:21
@callstack-bot
Copy link
Copy Markdown

callstack-bot commented Mar 30, 2019 •
edited
Loading

Hey @raajnadar, thank you for your pull request 🤗. The documentation from this branch can be viewed here. Please remember to update Typescript types if you changed API.

@raajnadar raajnadar requested a review from pbitkowski April 2, 2019 10:47
@ferrannp
Copy link
Copy Markdown
Collaborator

ferrannp commented Apr 15, 2019

Thank you!

@ferrannp ferrannp merged commit 5e163e3 into callstack:master Apr 15, 2019
jbinda pushed a commit to jbinda/react-native-paper that referenced this pull request Apr 17, 2019
@raajnadar @jbinda
feat: custom icon for clear in seachbar (callstack#965)
aded6b8
iyadthayyil pushed a commit to iyadthayyil/react-native-paper that referenced this pull request Jun 6, 2019
@raajnadar @iyadthayyil
feat: custom icon for clear in seachbar (callstack#965)
d364212
@iyadthayyil iyadthayyil mentioned this pull request Jun 14, 2019
Closed
Trancever pushed a commit that referenced this pull request Jun 27, 2019
@raajnadar @Trancever
feat: custom icon for clear in seachbar (#965)
c23d4eb
@fabian-astorga fabian-astorga mentioned this pull request Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trancever Trancever Awaiting requested review from Trancever

@pbitkowski pbitkowski Awaiting requested review from pbitkowski

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unable to change a clear icon in Searchbar

3 participants

@raajnadar @callstack-bot @ferrannp