CI configuration updated #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commented part of CI workflow was about to be turned on once detox is configured and ready to be used. NOTE: This commit is about to TEST whether this part is still valid. If the CI workflow fail and cannot be fixed it should be removed or replaced if possible.
The Detox still have an issue with React Native and seems to not going forward with more support for it. It should not be slowing down the CI development - more convenient will be to configure the build and tests in old-fashioned way.
The Windows Example app is built using the windows@2.4.0 orb of CircleCI This configuration is based on self installed dependencies, as there's no `install` job in the CI workflow. This commit also adds the msbuild.binlog to the ignored files - this is the build result log file which can be changed anytime app is built.
The Android example app could not be compiled due to no `downloadDependencies` task. This is fixed by adding it to the build.gradle configuration, so that rn/android can utilize it.
The rn/ios_build job had an issue of being unable to build the workspace which would result in the static libraries unable to be found in the project. To avoid that the custom job has been implemented, which builds the iOS app from a workspace point of view, which has all the deps already linked and can be successfully used to verify the build.
BartoszKlonowski
added
enhancement
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CI workflow by:
(this somehow partially closes Fix detox to work with RN 0.60 #88)
The major update is that the example projects now use the Slider package which is pulled directly from the local workspace.
This is to test the build of the changes implemented within the PR and make sure that the implemented changes will build in the real app.
There are also minor changes implemented for this update:
test->slider-full-ciThis makes the name more descriptive, while
testcould indicate UT instead.This can emphasize the problem with UTs explicitly when ESLint and Flow are OK.