-
Notifications
You must be signed in to change notification settings - Fork 292
Add fabric on Android #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1b10c9a
Configure build.gradle
okwasniewski 533cf64
Update libraryName on android
okwasniewski 2cdd58a
Create ReactSlider shared implementation
okwasniewski 5355ccc
Split implementations into oldarch and newarch
okwasniewski cbe260c
Dispatch events
okwasniewski 5e7fc19
Cleanup eventDispatcher
okwasniewski 8c1b1f9
Make oldarch implementation use shared code
okwasniewski f90d3af
Add defaults to js spec
okwasniewski 7da2e28
Clean up newarch ReactSliderManager
okwasniewski 88958e4
Reorder props to fix disabled state
okwasniewski e1d479e
Handle TestID setter
okwasniewski 23ddf41
Move ReactSliderShadowNode to shared implementation
okwasniewski 3701d57
Share getExportedCustomDirectEventTypeConstants
okwasniewski e3ac534
Remove comments, add empty line
okwasniewski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
258 changes: 0 additions & 258 deletions
258
package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderManager.java
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.