Skip to content

Fix: Pods-related error after using Pods from cache #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 28, 2022
Merged

Fix: Pods-related error after using Pods from cache #407

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
07cff6c
Bring back Pods to cache
BartoszKlonowski Jul 28, 2022
8f7cd5d
Use new-arch string in key for new arch cache
BartoszKlonowski Jul 28, 2022
c386805
Try to reinstall pods instead of creating new
BartoszKlonowski Jul 28, 2022
6a2135e
Separate deps installation between two caches
BartoszKlonowski Jul 28, 2022
7b6ef84
Rename Pods reinstall step
BartoszKlonowski Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 39 additions & 13 deletions .github/workflows/ReactNativeSlider-CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,20 +105,33 @@ jobs:
id: cache-npm
uses: actions/cache@v3
env:
cache-name: cached-ios-deps
cache-name: cached-ios-npm-deps
with:
path: |
example/node_modules
path: example/node_modules
key: ${{ hashFiles('./example/package-lock.json') }}-${{ hashFiles('./package/package-lock.json') }}

- name: Install required dependencies on cache miss (npm)
if: steps.cache-npm.outputs.cache-hit != 'true'
run: |
npm install

- name: Install pods
run: pod install --verbose
working-directory: example/ios
- name: Cache Pods
id: cache-pods
uses: actions/cache@v3
env:
cache-name: cached-ios-pods-deps
with:
path: example/ios/Pods
key: ${{ hashFiles('./example/ios/Podfile.lock') }}

- name: Install required dependencies on cache miss (Pods)
if: steps.cache-pods.outputs.cache-hit != 'true'
run: |
cd example/ios && pod install

- name: Reinstall Pods only if using cached ones
if: steps.cache-pods.outputs.cache-hit == 'true'
run: cd example/ios && pod install

- name: Use the current package sources in build
run: cd example && npm run refresh-package
Expand All @@ -144,20 +157,33 @@ jobs:
id: cache-npm
uses: actions/cache@v3
env:
cache-name: cached-ios-deps
cache-name: cached-ios-npm-deps
with:
path: |
example/node_modules
key: ${{ hashFiles('./example/package-lock.json') }}-${{ hashFiles('./package/package-lock.json') }}
path: example/node_modules
key: new-arch-${{ hashFiles('./example/package-lock.json') }}-${{ hashFiles('./package/package-lock.json') }}

- name: Install required dependencies on cache miss (npm)
if: steps.cache-npm.outputs.cache-hit != 'true'
run: |
npm install

- name: Install pods
run: RCT_NEW_ARCH_ENABLED=1 pod install
working-directory: example/ios
- name: Cache Pods
id: cache-pods
uses: actions/cache@v3
env:
cache-name: cached-ios-pods-deps
with:
path: example/ios/Pods
key: new-arch-${{ hashFiles('./example/ios/Podfile.lock') }}

- name: Install required dependencies on cache miss (Pods)
if: steps.cache-pods.outputs.cache-hit != 'true'
run: |
cd example/ios && RCT_NEW_ARCH_ENABLED=1 pod install

- name: Reinstall Pods only if using cached ones
if: steps.cache-pods.outputs.cache-hit == 'true'
run: cd example/ios && RCT_NEW_ARCH_ENABLED=1 pod install

- name: Use the current package sources in build
run: cd example && npm run refresh-package
Expand Down