[Fabric] Refactor events, remove unused code #422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Aug 29, 2022
troZee
requested changes
Aug 30, 2022
package/android/src/newarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
Show resolved
Hide resolved
troZee
approved these changes
Aug 30, 2022
BartoszKlonowski
approved these changes
Sep 6, 2022
Member
BartoszKlonowski
left a comment
BartoszKlonowski
left a comment
There was a problem hiding this comment.
Ready to merge as soon as indents are corrected 👍
package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
Outdated
Show resolved
Hide resolved
package/android/src/main/java/com/reactnativecommunity/slider/ReactSliderEvent.java
Outdated
Show resolved
Hide resolved
This was referenced Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to this discussion, ShadowNodes are not used in the new architecture so I moved it back to old arch.
Regarding events:
Source: react-native source code
Test Plan:
CI
This pull request fixes #412