Conversation
🦋 Changeset detectedLatest commit: 458be3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
canary for testing: https://www.npmjs.com/package/@callstack/repack/v/5.0.0-canary-20250219102750 |
thymikee
approved these changes
Feb 19, 2025
Member
thymikee
left a comment
thymikee
left a comment
There was a problem hiding this comment.
I have no idea what I'm reading here 🙈
Contributor
Author
|
tested the canary in super-app-showcase, all green 🟢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces reworked HMR pipeline which closely resembles the implementation from Rsbuild. The reworked HMR implementation is faster, has better error recovery (even from compile errors like syntax errors) and when it fails, it fails more gracefully instead of spamming the terminal with useless logs.
Closes #999
WebpackHMRClientimplementationWebsocketServerclassTest plan