Skip to content

feat: add graphic logo#1024

Merged
jbroma merged 1 commit intocallstack:mainfrom
borisyankov:logo
Feb 26, 2025
Merged

feat: add graphic logo#1024
jbroma merged 1 commit intocallstack:mainfrom
borisyankov:logo

Conversation

@borisyankov
Copy link
Copy Markdown
Contributor

Brings the console game of Re.Pack up to the standard of Metro and Expo by displaying a graphic logo:

Screenshot 2025-02-23 at 19 16 24

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 23, 2025

🦋 Changeset detected

Latest commit: 3a8a85e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Major
@callstack/repack-plugin-expo-modules Major
@callstack/repack-plugin-nativewind Major
@callstack/repack-plugin-reanimated Major
@callstack/repack-dev-server Major
@callstack/repack-init Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 2:04pm

@jbroma
Copy link
Copy Markdown
Contributor

jbroma commented Feb 24, 2025

thanks for the PR, that's definetly the best looking representation of the Re.Pack i've seen in the terminal, i just feel like it's too big and too intrusive, can you try something half the size?

@borisyankov
Copy link
Copy Markdown
Contributor Author

How does that look?

image

@borisyankov
Copy link
Copy Markdown
Contributor Author

Last change, using the same gradient from Re.Pack Init:
image

(text on next line, maybe need to only say the version)

@borisyankov
Copy link
Copy Markdown
Contributor Author

Importing 'gradient-string' the way I do it... not sure if correct? (using 'import' errors out), and fails a test.

Copy link
Copy Markdown
Contributor

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love the gradient one!

Comment thread packages/repack/src/commands/rspack/logo.ts Outdated
Comment thread packages/repack/src/commands/rspack/logo.ts Outdated
Comment thread packages/repack/src/commands/rspack/start.ts Outdated
Comment thread packages/repack/src/commands/rspack/logo.ts Outdated
Comment thread packages/repack/package.json Outdated
Comment thread packages/repack/src/commands/rspack/start.ts Outdated
@borisyankov
Copy link
Copy Markdown
Contributor Author

Final version, looks like:

image

Copy link
Copy Markdown
Contributor

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last 2 nits

Comment thread packages/repack/src/commands/common/logo.ts Outdated
Comment thread packages/repack/src/commands/webpack/start.ts Outdated
@jbroma
Copy link
Copy Markdown
Contributor

jbroma commented Feb 26, 2025

also please add changeset and would be nice to make a subsequent PR adding this to @callstack/repack-init

@borisyankov
Copy link
Copy Markdown
Contributor Author

Changeset added.

Copy link
Copy Markdown
Contributor

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant, great work @borisyankov 🚀

@jbroma jbroma merged commit 5e68814 into callstack:main Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants