Skip to content

Conversation

@ismarbesic
Copy link
Contributor

Summary

The path of the hermesc binary was recently changed to support bundling the app using hermes v1, see facebook/react-native#53581. This makes the HermesBytecodePlugin fail since the old path isn't present anymore in React Native 0.82+. This PR adds support for the new path while preserving a fallback to the old path.

Test plan

  • Make sure the app compiles with older react native versions. The test app can be used for this.
  • Make sure the app compiles with newer react native versions. This has been tested with a RN 0.83 example app.

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2026

🦋 Changeset detected

Latest commit: 2973650

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-expo-modules Patch
@callstack/repack-plugin-nativewind Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 26, 2026

@ismarbesic is attempting to deploy a commit to the Callstack Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thank you for your contribution 🎉

The change looks good, I see that you have also included the compatibility for previous RN versions 🚀

@ismarbesic
Copy link
Contributor Author

Thanks @jbroma @thymikee. I missed there were test cases for this. Those should be updated now and also added a test case to cover the new path and old path.

@vercel
Copy link

vercel bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
repack-website Ready Ready Preview, Comment Feb 2, 2026 4:28pm

Request Review

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jbroma jbroma merged commit cbfcfd0 into callstack:main Feb 2, 2026
5 checks passed
@jbroma
Copy link
Member

jbroma commented Feb 2, 2026

Thanks again for your contribution @ismarbesic 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants