refactor(webpack/Compiler): remove duplicated assets in assetCache#276
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e435bbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thymikee
approved these changes
Dec 12, 2022
|
|
||
| export const adaptFilenameToPlatform = (filename: string) => { | ||
| if (isWindows) { | ||
| return filename.replace(/\\/g, '/'); |
Member
There was a problem hiding this comment.
not sure if we use it already, but if we do, we could use slash library to do so
RafikiTiki
force-pushed
the
refactor/remove-dupliated-assets-in-assetsCache
branch
from
c097271 to
e435bbc
Compare
Contributor
|
Hi |
Contributor
|
tested, seems to be working as expected, didn't encounter any issue |
RafikiTiki
deleted the
refactor/remove-dupliated-assets-in-assetsCache
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR slightly refactors what was already implemented by @meypod in #256 – instead of duplicating each asset under a key which is valid pathname for Windows I'm modifying (or not) the filename based on the platform in context of which
Complieris run. This should be safe as it will not affect production builds because theCompilerin only used with devServer.Test plan
Unfortunately I don't have access to a machine running Windows – @meypod would you be able to test that change and let me know if it's working properly on your end?