chore(repack): Update kotlin-gradle-plugin version#294
Merged
Conversation
🦋 Changeset detectedLatest commit: ae4efee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
c1572c2 to
81f067f
Compare
thymikee
approved these changes
Jan 23, 2023
81f067f to
ae4efee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In clean RN project created using CLI (RN version – 0.71.1) there was an error while build Android app. More context can be found in this issue: #291. Upgrading kotlin-gradle-plugin version specified in Repack solves that issue without the need to manually specify kotlin-gradle-plugin version override in the repack consumers their codebases.
Test plan
Tested in latest RN version (0.71.1) and a reasonably old one – 0.67.5 – in both cases clean RN app configured to be built using repack is working fine (in both debug and release).