feat(repack): resolve scale automatically for inlined assets#328
Merged
Conversation
🦋 Changeset detectedLatest commit: 99ba5e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
06af660 to
88a78a4
Compare
RafikiTiki
approved these changes
Apr 4, 2023
thymikee
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added automatic scale resolution for inlined assets. This change only affects scaled inlined assets.
This resolves an issue where an unstyled
Imagewith inlined source was not being displayed (the width & height won't be picked up properly unless it's a singleURISourceResult of inlining scaled asset before:
Result of inlining scaled asset after:
Test plan