Skip to content

chore(TesterApp): Improve remote assets and bundles serving for TesterApp #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RafikiTiki merged 1 commit into from
Apr 7, 2023
Merged

chore(TesterApp): Improve remote assets and bundles serving for TesterApp #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/famous-clouds-sparkle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"testerapp": patch
---

Improve the way remote assets and bundle are served for Release builds of the TesterApp
2 changes: 1 addition & 1 deletion packages/TesterApp/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ScriptManager.shared.addResolver(async (scriptId, _caller) => {
}

return {
url: Script.getRemoteURL(`http://localhost:5000/${scriptId}`),
url: Script.getRemoteURL(`http://localhost:9999/${scriptId}`),
};
});

Expand Down
6 changes: 3 additions & 3 deletions packages/TesterApp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"android": "react-native run-android",
"ios": "react-native run-ios",
"start": "react-native webpack-start",
"bundle": "react-native webpack-bundle --platform ios --entry-file index.js --dev=false",
"webpack": "webpack -c webpack.config.js --env platform=ios --env mode=production",
"bundle": "react-native webpack-bundle --platform android --entry-file index.js --dev=false",
"webpack": "webpack -c webpack.config.js --env platform=android --env mode=production",
"test": "vitest run",
"serve-remote-assets": "yarn http-server -p 9999 build/output/ios/remote/remote-assets"
"serve-remote-assets": "yarn http-server -p 9999 build/output/android/remote && adb reverse tcp:9999 tcp:9999"
Comment thread
RafikiTiki marked this conversation as resolved.
},
"dependencies": {
"@callstack/repack": "3.2.0-rc.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/TesterApp/webpack.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export default (env) => {
scalableAssetExtensions: Repack.SCALABLE_ASSETS,
remote: {
enabled: true,
publicPath: 'http://localhost:9999',
publicPath: 'http://localhost:9999/remote-assets',
},
},
},
Expand Down