Skip to content

fix(init): fix bad package name in handleReactNativeConfig #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RafikiTiki merged 3 commits into from
May 23, 2023
Merged

fix(init): fix bad package name in handleReactNativeConfig #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bffc95e
fix(init): fix bad package name in handleReactNativeConfig
jbroma May 22, 2023
1c7fc6c
chore(init): add changeset
jbroma May 22, 2023
f92c40c
Merge branch 'main' into fix/init-rn-commands
RafikiTiki May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-rockets-double.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack-init": patch
---

Fix bad package name when creating/updating react-native.config.js
8 changes: 4 additions & 4 deletions packages/init/src/tasks/handleReactNativeConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import logger from '../utils/logger.js';

const defaultConfig = dedent`
module.exports = {
commands: require('repack/commands'),
}`;
commands: require('@callstack/repack/commands'),
};`;

/**
* Checks whether react-native.config.js exists and adds the commands to it
Expand All @@ -29,14 +29,14 @@ export default function handleReactNativeConfig(cwd: string): void {
if (!configContent.includes('commands:')) {
updatedConfigContent = configContent.replace(
'module.exports = {',
"module.exports = {\n commands: require('repack/commands'),"
"module.exports = {\n commands: require('@callstack/repack/commands'),"
);
} else {
const commandsIndex = configContent.indexOf('commands:');
const commandsEndIndex = configContent.indexOf(',', commandsIndex);
const commandsString = configContent.slice(commandsIndex, commandsEndIndex);

const newCommandsString = `commands: require('repack/commands')`;
const newCommandsString = `commands: require('@callstack/repack/commands')`;
if (commandsString === newCommandsString) {
logger.success('File react-native.config.js is already up to date');
return;
Expand Down