refactor(repack): improve HMR performance #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b0ab7fe The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
thymikee
approved these changes
Sep 26, 2023
RafikiTiki
approved these changes
Sep 28, 2023
RafikiTiki
force-pushed
the
refactor/hmr-performance-logger-plugin
branch
from
db15789 to
ddac722
Compare
jbroma
force-pushed
the
refactor/hmr-performance-logger-plugin
branch
from
ddac722 to
b0ab7fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a performance improvement for HMR in the
@callstack/repackpackage.Changes:
LoggerPlugin.tsto improve performance. Specifically, an update has been made to thestats.toJsonmethod. By addingall: falsewe disable retrieving other stats that were being needlessly retrieved by default.Performance Metrics:
HMR time:
LoggerPlugin
donehook time: