Skip to content

fix: ScriptManager import path in MF runtime plugins (CorePlugin & ResolverPlugin) #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbroma merged 3 commits into from
Dec 20, 2024
Merged

fix: ScriptManager import path in MF runtime plugins (CorePlugin & ResolverPlugin) #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
550c55d
fix: Module Resolution Errors for ScriptManager Imports
mrsasuu Dec 20, 2024
6b704ee
chore: Lint
mrsasuu Dec 20, 2024
e8fdf89
chore: Changeset updated
mrsasuu Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lazy-comics-promise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack": patch
---

Fix ScriptManager import path in MF runtime plugins (CorePlugin & ResolverPlugin)
2 changes: 1 addition & 1 deletion packages/repack/src/modules/FederationRuntimePlugins/CorePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import type * as RepackClient from '../ScriptManager/index.js';
const RepackCorePlugin: () => FederationRuntimePlugin = () => ({
name: 'repack-core-plugin',
loadEntry: async ({ remoteInfo }) => {
const client = require('../ScriptManager.js') as typeof RepackClient;
const client = require('../ScriptManager/index.js') as typeof RepackClient;
const { ScriptManager, getWebpackContext } = client;
const { entry, entryGlobalName } = remoteInfo;

Expand Down
2 changes: 1 addition & 1 deletion packages/repack/src/modules/FederationRuntimePlugins/ResolverPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const RepackResolverPlugin: (
name: 'repack-resolver-plugin',
afterResolve(args) {
const { ScriptManager } =
require('../ScriptManager.js') as typeof RepackClient;
require('../ScriptManager/index.js') as typeof RepackClient;
const { remoteInfo } = args;

ScriptManager.shared.addResolver(
Expand Down