Add cssInterop options to the Nativewind plugin#890
Merged
jbroma merged 2 commits intocallstack:mainfrom Jan 22, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: a6af8a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
ceopaludetto
force-pushed
the
feat/nativewind-css-options
branch
from
30d8b00 to
4380558
Compare
ceopaludetto
changed the title
jbroma
reviewed
Jan 21, 2025
Contributor
jbroma
left a comment
jbroma
left a comment
There was a problem hiding this comment.
thank you for your contribution @ceopaludetto, everything looks good overall.
One nit - I think we could make the prop name shorter like in the suggestions, WDYT?
ceopaludetto
force-pushed
the
feat/nativewind-css-options
branch
from
4380558 to
70c2f8c
Compare
ceopaludetto
force-pushed
the
feat/nativewind-css-options
branch
from
70c2f8c to
a6af8a9
Compare
jbroma
changed the title
Contributor
|
Thank you again for your contribution @ceopaludetto 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new
cssToReactNativeRuntimeOptionsoption (name suggestions are welcome) that forwards directly tocssToReactNativeRuntimeallowing configurations likeinlineRemandselectorPrefixTest plan