Skip to content

fix: don't error on missing --entry-file when entry is defined in rspack/webpack.config.js#950

Merged
jbroma merged 4 commits intomainfrom
fix/use-default-entry-file
Feb 5, 2025
Merged

fix: don't error on missing --entry-file when entry is defined in rspack/webpack.config.js#950
jbroma merged 4 commits intomainfrom
fix/use-default-entry-file

Conversation

@szymonrybczak
Copy link
Copy Markdown
Contributor

Summary

We shouldn't exit with an error if there's no --entry-file option passed, because in we have the same value in rspack.config.js under entry.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 0d874c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2025 0:42am

@szymonrybczak szymonrybczak changed the title fix: read entry property from config before --entry-file fix: don't error on missing --entry-file when entry is defined in rspack.config.js Feb 5, 2025
@szymonrybczak szymonrybczak changed the title fix: don't error on missing --entry-file when entry is defined in rspack.config.js fix: don't error on missing --entry-file when entry is defined in rspack/webpack.config.js Feb 5, 2025
@jbroma jbroma changed the title fix: don't error on missing --entry-file when entry is defined in rspack/webpack.config.js fix: don't error on missing --entry-file when entry is defined in rspack/webpack.config.js Feb 5, 2025
Copy link
Copy Markdown
Contributor

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one 👍

@jbroma jbroma merged commit 580bf30 into main Feb 5, 2025
@jbroma jbroma deleted the fix/use-default-entry-file branch February 5, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants