Skip to content

refactor: normalise plugin names and error formatting#968

Merged
jbroma merged 4 commits intomainfrom
refactor/normalise-plugin-names
Feb 10, 2025
Merged

refactor: normalise plugin names and error formatting#968
jbroma merged 4 commits intomainfrom
refactor/normalise-plugin-names

Conversation

@jbroma
Copy link
Copy Markdown
Contributor

@jbroma jbroma commented Feb 10, 2025

Summary

  • - every plugin registers with Rspack/webpack API using Repack<plugin> convention
  • - every plugin reports errors with the plugi name in front in brackets

Test plan

n/a

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: a081604

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@callstack/repack Patch
@callstack/repack-plugin-reanimated Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 4:42pm

@jbroma jbroma changed the title refactor: normalise plugin names refactor: normalise plugin names and error formatting Feb 10, 2025
@jbroma jbroma requested a review from szymonrybczak February 10, 2025 16:45
Copy link
Copy Markdown
Contributor

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌. How about Reanimated and Natewind plugins?

@jbroma
Copy link
Copy Markdown
Contributor Author

jbroma commented Feb 10, 2025

👌. How about Reanimated and Natewind plugins?

oh nice find! forgot about those :D

EDIT: no need for adjustments there, merging as is 👍

@jbroma jbroma merged commit 59d9d02 into main Feb 10, 2025
@jbroma jbroma deleted the refactor/normalise-plugin-names branch February 10, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants