Skip to content

feat: deprecate getPublicPath and make it a no-op#975

Merged
jbroma merged 9 commits intomainfrom
feat/remove-get-public-path
Feb 12, 2025
Merged

feat: deprecate getPublicPath and make it a no-op#975
jbroma merged 9 commits intomainfrom
feat/remove-get-public-path

Conversation

@jbroma
Copy link
Copy Markdown
Contributor

@jbroma jbroma commented Feb 12, 2025

Summary

  • - make getPublicPath a no-op and deprecate it
  • - add automatic public path handling in DevelopmentPlugin for development
  • - use noop:/// as default publicPath
  • - remove deprecated getPublicPath function usage from all config files
  • - remove get-public-path from documentation

Test plan

  • - testers work
  • - tests pass

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2025 6:27pm

@jbroma
Copy link
Copy Markdown
Contributor Author

jbroma commented Feb 12, 2025

@thymikee we could make this non breaking by making the getPublicPath helper function a noop (since it will be configured internally anyways in the exact same way)

can mark is as deprecated and scheduled for removal

@jbroma
Copy link
Copy Markdown
Contributor Author

jbroma commented Feb 12, 2025

cc @szymonrybczak

@thymikee
Copy link
Copy Markdown
Member

we could make this non breaking by making the getPublicPath helper function a noop (since it will be configured internally anyways in the exact same way)
can mark is as deprecated and scheduled for removal

let's do this and inform the user that they can safely remove it

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 852594d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@callstack/repack Major
@callstack/repack-plugin-expo-modules Major
@callstack/repack-plugin-nativewind Major
@callstack/repack-plugin-reanimated Major
@callstack/repack-dev-server Major
@callstack/repack-init Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jbroma jbroma changed the title [BREAKING] feat: remove getPublicPath feat: deprecate getPublicPath and make it a no-op Feb 12, 2025
@jbroma jbroma marked this pull request as ready for review February 12, 2025 18:27
@jbroma jbroma merged commit 7c9232c into main Feb 12, 2025
@jbroma jbroma deleted the feat/remove-get-public-path branch February 12, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants