Skip to content

fix: EXPO_OS not being set in expo-modules plugin#986

Merged
jbroma merged 2 commits into
mainfrom
fix/expo-modules-plugin
Feb 13, 2025
Merged

fix: EXPO_OS not being set in expo-modules plugin#986
jbroma merged 2 commits into
mainfrom
fix/expo-modules-plugin

Conversation

@jbroma
Copy link
Copy Markdown
Contributor

@jbroma jbroma commented Feb 13, 2025

Summary

  • - use compiler.options.name instead of compiler.name
  • - call apply on DefinePlugin

Test plan

  • - testers work

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 13, 2025

🦋 Changeset detected

Latest commit: a580291

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@callstack/repack-plugin-expo-modules Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Feb 13, 2025 5:36pm

@jbroma jbroma merged commit 802d15b into main Feb 13, 2025
@jbroma jbroma deleted the fix/expo-modules-plugin branch February 13, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant