Skip to content

[BREAKING] feat: configure OutputPlugin directly through CLI#987

Merged
jbroma merged 10 commits intomainfrom
feat/pass-output-plugin-options-through-env
Feb 13, 2025
Merged

[BREAKING] feat: configure OutputPlugin directly through CLI#987
jbroma merged 10 commits intomainfrom
feat/pass-output-plugin-options-through-env

Conversation

@jbroma
Copy link
Copy Markdown
Contributor

@jbroma jbroma commented Feb 13, 2025

Summary

  • - BREAKING: remove bundleFilename, sourceMapFilename, assetsPath from OutputPlugin configuration - these properties are now obtained directly from the CLI args and are modifiable only through the respective CLI flags.
  • - BREAKING: BREAKING: remove bundleFilename, sourceMapFilename, assetsPath from RepackPlugin configuration - these properties are now obtained directly from the CLI args and are modifiable only through the respective CLI flags.
  • - added deprecation messages for the aforementioned properties
  • - added setupEnvironment utility that sets selected process.env variables based on CLI args
  • - removed now redundant properties in configs & templates

Test plan

  • - tests pass
  • - testers work

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 13, 2025

⚠️ No Changeset found

Latest commit: 4b6330d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
repack-website ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 9:56pm

@jbroma jbroma changed the title feat: configure OutputPlugin directly through CLI [BREAKING] feat: configure OutputPlugin directly through CLI Feb 13, 2025
@jbroma jbroma marked this pull request as ready for review February 13, 2025 21:56
@jbroma jbroma merged commit 97cd8e8 into main Feb 13, 2025
@jbroma jbroma deleted the feat/pass-output-plugin-options-through-env branch February 13, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant