Skip to content

refactor: make platform optional in DevelopmentPlugin #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbroma merged 2 commits into from
Feb 13, 2025
+10 −2
Merged

refactor: make platform optional in DevelopmentPlugin #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a730633
refactor: make platform optional in development plugin
jbroma Feb 13, 2025
e744c61
chore: changeset
jbroma Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/many-ants-rescue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@callstack/repack": patch
---

Make `platform` option of DevelopmentPlugin optional
7 changes: 5 additions & 2 deletions packages/repack/src/plugins/DevelopmentPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ type PackageJSON = { version: string };
* {@link DevelopmentPlugin} configuration options.
*/
export interface DevelopmentPluginConfig {
platform: string;
/**
* Target application platform.
*/
platform?: string;
}

/**
Expand Down Expand Up @@ -103,7 +106,7 @@ export class DevelopmentPlugin implements RspackPluginInstance {
const host = compiler.options.devServer.host;
const port = compiler.options.devServer.port;
const protocol = this.getProtocolType(compiler.options.devServer);
const platform = this.config.platform;
const platform = this.config.platform ?? (compiler.options.name as string);

new compiler.webpack.DefinePlugin({
__PLATFORM__: JSON.stringify(platform),
Expand Down