Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Users can now run
agent-cdp target listwithout--urlto scan the default local Chrome, Node.js, and React Native CDP endpoints, then select any returned target withagent-cdp target select <id>without repeating the URL.Context
Target ids now embed the discovery source using a base64url-encoded source segment, which keeps ids stable across Chrome, Node.js, React Native, and arbitrary custom discovery URLs. Selection decodes the source from the id, narrows discovery to that endpoint, and still allows
--urlas an optional consistency check.Proposed Testing Scenario
Start a Chrome instance with remote debugging on
9222, a Node.js process with--inspect, or a React Native Metro server on8081, then runagent-cdp target listwithout--urland verify that targets from the available endpoints are listed with source-aware ids. Select one of those ids withagent-cdp target select <id>and confirm follow-up commands use the chosen target without providing--url; optionally retry with a matching and mismatching--urlto confirm the consistency check behavior.