feat: add simulator-set and Android allowlist isolation#143
Merged
Conversation
thymikee
force-pushed
the
codex/simulator-set-allowlist-isolation
branch
from
89b7ee8 to
7a21a50
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add first-class scoped device isolation for iOS simulators and Android devices.
--ios-simulator-device-set(and env equivalents) and propagate to iOS discovery + simctl-backed command execution.--android-device-allowlist(and env equivalents) and enforce allowlist filtering in Android discovery/selection.Touched files: 19.
Scope expansion: yes, expanded from iOS-only into Android discovery path by explicit follow-up request.
Validation
pnpm typecheckpnpm test:unitpnpm test:smokepnpm test:integration(fails in this environment attest/integration/android.test.ts:29due Settings UI-content assertion mismatch; unchanged by this PR)