Conversation
…devices On Android emulators with multiple displays (e.g. Galaxy Z Fold), `adb exec-out screencap -p` writes a warning to stdout before the PNG data, producing corrupt files. Locate the PNG signature in the buffer and discard everything before it. https://claude.ai/code/session_01Lfb3WKqXCSqYtCg8dbS8JW
- Remove unnecessary ternary; subarray(0) is a no-op - Replace hex-encoded printf mock scripts with file-based payloads https://claude.ai/code/session_01Lfb3WKqXCSqYtCg8dbS8JW
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
adb exec-out screencap -pcan write warning text to stdout before PNG bytes, producing corrupt screenshot files.IEND, so trailing stdout garbage is stripped as well.Fixes #184
Validation
pnpm typechecknode --test src/platforms/android/__tests__/snapshot.test.tsagent-device screenshot, verify valid PNG output