feat: replace bulky skills with versioned CLI help#352
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
6b79dcc to
6a1f630
Compare
ea8fb83 to
21c037e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move agent operating guidance from large installed skill reference trees into version-matched
agent-device helptopics, while keeping published skills as tiny routers that point agents at the installed CLI's own help.Before
skills/**/references.agent-deviceCLI version.After
agent-device helpincludes anAgent Quickstartand workflow links for agents that only run plain help.agent-device help workflowcarries bootstrap, exploration, targeting, validation, React Native, Expo, remote/cloud, macOS, dogfood routing, and Shopify-style workaround guidance.help workflownow includes a compact snapshot legend showing@e12refs, labels/ids, truncated previews, disabled/hittable state, and off-screen hints.open,installmeansinstall, freshness comes fromopen --relaunch, and Expo URLs should not be searched for when the task already gives a launch target.logs clear --restartandnetwork dump --include headers.clipboard writeprefill for app behavior, and Android non-ASCII text stays onfill/typewith trusted ADB keyboard IME as the external fallback.debugging,react-devtools,remote,macos, anddogfood.agent-device,react-devtools, anddogfoodskills are small routers with a requiredagent-device >= 0.13.4compatibility gate and upgrade instruction.test/skillgymdocs remain for maintainers.BASE_INSTRUCTIONSis intentionally thin and points agents at local CLI help instead of embedding a command cheat sheet.pnpm test:skillgymbuilds before running, the runner is renamedcodex-main->codex-mini, per-case timeout is 10m, and scheduling isisolated-by-runner.Guidance Coverage
Restored and regression-tested high-value guidance from the removed skill references and Shopify feedback:
devices/apps, install vs open, GitHub Actions artifact install, Expo Go/dev-client URLs, freshopen --relaunchafter installssnapshot/get/is/find,snapshot -iwhen refs are needed, scoped snapshots for truncated inputs@e12refs, raw coordinate fallback only for iOS disabled/no-op refs or collapsed composite controlsdiff snapshot, overlay refs for visual evidence,waitfor async/list text presenceconnect --remote-config, per-command script flow, lease/tenant config, local service tunnelsSize And Quality
origin/main-> 541 words / 4,042 bytes now.BASE_INSTRUCTIONS: 75 words / 483 bytes.agent-device help: 1,038 words / 12,060 bytes.agent-device help workflow: 1,297 words / 9,955 bytes.codex-mini: 64/66 cases, 64/66 runsclaude-haiku: 63/66 cases, 63/66 runssetup-unknown-app-discover-first,install-from-github-artifact-before-open,debug-logs-short-window,debug-network-session-dump.Validation
pnpm formatpnpm vitest run src/__tests__/cli-help.test.ts src/utils/__tests__/args.test.tspnpm vitest run src/__tests__/cli-help.test.ts src/utils/__tests__/args.test.ts src/core/__tests__/batch.test.tspnpm typecheckpnpm buildnode bin/agent-device.mjs --version->0.13.4pnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --runner codex-mini-> 64/66; outputtest/skillgym/.skillgym-results/2026-04-27T22-43-14-618Zpnpm exec skillgym run ./test/skillgym/suites/agent-device-smoke-suite.ts --config ./test/skillgym/skillgym.config.ts --runner claude-haiku-> 63/66; outputtest/skillgym/.skillgym-results/2026-04-27T23-32-38-591Zsetup-unknown-app-discover-first,install-from-github-artifact-before-open,debug-logs-short-window,debug-network-session-dumpopen-and-snapshot,setup-unknown-app-discover-first,install-artifact-before-openios-allow-paste-prefill-only,android-non-ascii-text-stays-in-filltarget-ref-after-interactive-snapshot,ios-disabled-row-raw-rect-fallback,ios-composite-horizontal-tabs-coordinate-fallback,list-text-presence-prefers-wait-text,navigation-back-ambiguous-use-visible-nav,batch-inline-step-schema-positionals,form-keyboard-dismiss,catalog-search-debounce,install-from-github-artifact-before-open,remote-config-script-flowKnown gap: I started one final full
codex-minirerun after the latest fixes, but stopped it when correcting the version-floor mistake back to0.13.4. The changed and previously failing cases were run directly on both runners.