ci: remove redundant Linux validation and fix unit hang#411
Merged
Conversation
|
thymikee
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the duplicate
Linux / Typecheck & Unit Testsvalidate job from the Linux workflow so Linux smoke no longer depends on a duplicated typecheck/unit gate.Add the required Metro bridge scope to the packaged Metro smoke config and assert that tenant/run/lease scope is sent to companion registration and bridge requests. This fixes the CI unit-suite hang after scoped Metro bridge calls started requiring that scope.
Touched-file count: 2. Scope expanded from Linux workflow cleanup to the packaged Metro smoke test because the CI unit timeout was still reproducing.
Validation
pnpm install --frozen-lockfilepnpm check:toolingpnpm exec vitest run src/__tests__/cli-client-commands.test.ts --reporter=verbosepnpm exec vitest run src/__tests__/client-metro-packaged.test.ts --reporter=verbosepnpm formatpnpm check:unitCI / Unit Testspassed on commit3028da1bin 1m7s: https://github.com/callstackincubator/agent-device/actions/runs/24450166229/job/71436764467