fix: use bridge metro runtime descriptors#425
Merged
Conversation
|
40e0f90 to
d52ee18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use bridge-provided Metro runtime descriptors as the source of truth for bridged Metro sessions.
ios_runtime.metro_bundle_urlin/api/metro/bridgerequestsmetroPublicBaseUrland rely onmetroProxyBaseUrlas the bridge origin/api/metro/runtimes/<runtimeId>/...routesTouched files: 17. Scope stayed within the remote Metro/client API and related docs/tests.
Compatibility note: this expects a descriptor-driven bridge server that accepts
/api/metro/bridgewithout a client-providedios_runtime. Older bridge servers that still requireios_runtime.metro_bundle_urlneed to be updated before pairing with this client behavior.Validation
pnpm formatpnpm check:quickpnpm check:unitnode --test test/integration/installed-package-metro.test.ts