Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5687c8cafe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (command === 'react-devtools') { | ||
| positionals.push(arg); | ||
| continue; |
There was a problem hiding this comment.
Keep global flags parseable after react-devtools command
This early return makes every token after react-devtools bypass flag parsing, so standard global options like --json, --debug, --config, or --session are no longer recognized when users place them after the command (the ordering used by other commands). For example, agent-device react-devtools status --json now forwards --json to the downstream tool instead of applying agent-device JSON behavior, which can break existing automation and contradict the command help’s global-flag contract. Parse global flags normally and only passthrough the remainder after an explicit boundary (or equivalent logic).
Useful? React with 👍 / 👎.
Summary
Adds
agent-device react-devtools [...args]as a CLI-side passthrough to pinnedagent-react-devtools@0.4.0for React Native component tree inspection and render profiling.Updates README, website docs, and bundled skills so React Native internals workflows are discoverable. Touched 20 files; scope stayed within the new command, tests, docs, and skills.
Validation
pnpm formatpnpm check:quickpnpm test:unit -- src/__tests__/cli-react-devtools.test.ts src/__tests__/cli-help.test.ts src/utils/__tests__/args.test.tsnode --experimental-strip-types src/bin.ts react-devtools --helpnode --experimental-strip-types src/bin.ts help react-devtools