fix: support remote Android React DevTools tunnel#438
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1418633f22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const exitCode = await runReactDevtoolsCommand(positionals, { | ||
| flags: effectiveFlags, | ||
| stateDir: daemonPaths.baseDir, | ||
| session: sessionName, |
There was a problem hiding this comment.
runReactDevtoolsCommand is called with sessionName, but sessionName is computed before remote-connection defaults are merged; when users omit --session and rely on an active remote session (often adc-*), this passes default instead of effectiveFlags.session. That registers the companion under the wrong consumer/session key, while disconnect/force cleanup later stops using the real state session (stopReactDevtoolsCleanup), so cleanup can miss the running companion and leave stale bridge state/processes behind for non-default sessions.
Useful? React with 👍 / 👎.
thymikee
force-pushed
the
codex/remote-android-react-devtools-tunnel
branch
2 times, most recently
from
3dbabb9 to
9909c17
Compare
thymikee
force-pushed
the
codex/remote-android-react-devtools-tunnel
branch
from
9909c17 to
4606339
Compare
1 participant
Summary
Support remote bridge React DevTools for Android by registering a lease-scoped companion tunnel to the sandbox-local DevTools daemon on port 8097.
Extend companion register/unregister handling, cleanup on command exit/disconnect, tests, and docs/skill guidance.
Touched files: 12. Scope stayed within the React DevTools/companion command family plus docs.
Validation
pnpm format
pnpm check:quick
pnpm check:unit