Conversation
|
04962d1 to
cf590e5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 04962d17c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const SENSITIVE_ASSIGNMENT_RE = | ||
| /\b(api[_-]?key|token|secret|password|user[_-]?code|device[_-]?code)(\s*[=:]\s*)("[^"]*"|'[^']*'|\S+)/gi; |
There was a problem hiding this comment.
Redact access_token-style assignments in string payloads
The new SENSITIVE_ASSIGNMENT_RE requires a word boundary before token, so strings like access_token=... and refresh_token=... are no longer matched and will pass through unredacted. This is a regression from the previous pattern and can leak bearer/OAuth credentials in diagnostic events and normalized error details when tokens appear in stderr or API response text blobs rather than as object keys.
Useful? React with 👍 / 👎.
cf590e5 to
f56c720
Compare
f56c720 to
c8c0cd2
Compare
Summary
devicesallocate/refresh leases before listingTouched-file count: 12. Scope stayed within remote connection/auth UX, docs, and tests.
Validation
pnpm formatpnpm vitest run src/__tests__/remote-connection.test.ts src/__tests__/cli-config.test.ts src/cli/__tests__/auth-session.test.ts src/utils/__tests__/diagnostics.test.ts src/__tests__/cli-help.test.tspnpm check:quickpnpm check:unit