Skip to content

fix: improve cloud remote auth UX#452

Merged
thymikee merged 1 commit intomainfrom
codex/cloud-remote-auth-ux
Apr 26, 2026
Merged

fix: improve cloud remote auth UX#452
thymikee merged 1 commit intomainfrom
codex/cloud-remote-auth-ux

Conversation

@thymikee
Copy link
Copy Markdown
Contributor

Summary

  • make pending remote leases actionable and have devices allocate/refresh leases before listing
  • preserve safe cloud API-token setup URLs during redaction while still scrubbing secrets
  • document cloud bridge/control-plane auth origins in CLI help, docs, and the packaged skill

Touched-file count: 12. Scope stayed within remote connection/auth UX, docs, and tests.

Validation

  • pnpm format
  • pnpm vitest run src/__tests__/remote-connection.test.ts src/__tests__/cli-config.test.ts src/cli/__tests__/auth-session.test.ts src/utils/__tests__/diagnostics.test.ts src/__tests__/cli-help.test.ts
  • pnpm check:quick
  • pnpm check:unit

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstackincubator.github.io/agent-device/pr-preview/pr-452/

Built to branch gh-pages at 2026-04-26 22:25 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@thymikee thymikee force-pushed the codex/cloud-remote-auth-ux branch from 04962d1 to cf590e5 Compare April 26, 2026 22:06
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 04962d17c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/utils/redaction.ts Outdated
Comment on lines +5 to +6
const SENSITIVE_ASSIGNMENT_RE =
/\b(api[_-]?key|token|secret|password|user[_-]?code|device[_-]?code)(\s*[=:]\s*)("[^"]*"|'[^']*'|\S+)/gi;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Redact access_token-style assignments in string payloads

The new SENSITIVE_ASSIGNMENT_RE requires a word boundary before token, so strings like access_token=... and refresh_token=... are no longer matched and will pass through unredacted. This is a regression from the previous pattern and can leak bearer/OAuth credentials in diagnostic events and normalized error details when tokens appear in stderr or API response text blobs rather than as object keys.

Useful? React with 👍 / 👎.

@thymikee thymikee force-pushed the codex/cloud-remote-auth-ux branch from cf590e5 to f56c720 Compare April 26, 2026 22:23
@thymikee thymikee force-pushed the codex/cloud-remote-auth-ux branch from f56c720 to c8c0cd2 Compare April 26, 2026 22:25
@thymikee thymikee merged commit 40fe5e2 into main Apr 26, 2026
16 checks passed
@thymikee thymikee deleted the codex/cloud-remote-auth-ux branch April 26, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant