fix: handle iOS keyboard Done dismiss controls#469
Merged
Conversation
thymikee
force-pushed
the
codex/fix-ios-keyboard-dismiss-done
branch
from
7819952 to
347f1ec
Compare
|
thymikee
force-pushed
the
codex/fix-ios-keyboard-dismiss-done
branch
from
347f1ec to
2e25b71
Compare
thymikee
force-pushed
the
codex/fix-ios-keyboard-dismiss-done
branch
from
2e25b71 to
961d22c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix iOS
keyboard dismissso the runner can tap common safeDonecontrols on keyboard keys, keyboard toolbars, and keyboard-adjacent app toolbars while preserving the unsupported error when the keyboard stays visible.Update workflow/docs/skill guidance and add a SkillGym regression so agents prefer
keyboard dismissbefore manually pressingDone.Touched files: 8. Scope stayed within iOS keyboard dismiss behavior and guidance.
Validation
pnpm formatpnpm check:quickpnpm test:unit src/__tests__/cli-help.test.ts src/utils/__tests__/args.test.tspnpm build:xcuitestgit diff --check