fix: require explicit bridge lease for devtools tunnel#487
Conversation
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ec6048b2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return flags.leaseBackend === 'android-instance' || flags.leaseBackend === 'ios-instance'; | ||
| } | ||
| return flags.platform === 'android' || flags.platform === 'ios'; | ||
| return flags.platform === 'android'; |
There was a problem hiding this comment.
This change makes isSupportedRemoteBridge return false for iOS whenever leaseBackend is absent, so react-devtools silently skips companion startup and falls back to local execution even when remote bridge inputs (for example metroProxyBaseUrl, tenant, runId, leaseId) are present. In practice this can break existing iOS remote flows that rely on platform-based inference (including legacy saved connection state or scripts that only pass --platform ios) with no actionable error, which is harder to diagnose than an explicit INVALID_ARGS failure.
Useful? React with 👍 / 👎.
thymikee
force-pushed
the
fix/ios-react-devtools-lease-gate
branch
from
0ec6048 to
e6f4bf9
Compare
thymikee
changed the title
thymikee
force-pushed
the
fix/ios-react-devtools-lease-gate
branch
from
e6f4bf9 to
bb6ee7c
Compare
thymikee
force-pushed
the
fix/ios-react-devtools-lease-gate
branch
from
bb6ee7c to
f3a3a7a
Compare
1 participant
Summary
android-instanceandios-instance; platform-only Android/iOS flags no longer opt in.Touched files: 3. Scope stayed within the React DevTools CLI command path and help text.
Validation
pnpm formatpnpm check:fallow --base origin/mainpnpm exec vitest run src/__tests__/cli-react-devtools.test.tspnpm exec vitest run src/utils/__tests__/args.test.tspnpm check:quick