fix: hide adb console windows on Windows#503
Merged
Merged
Conversation
|
thymikee
force-pushed
the
fix/android-adb-windows-console-hide
branch
from
9770c4a to
4aa0379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
windowsHide: trueon shared process helpers so Windows subprocesses do not flash console windows.Closes #502
Touched files: 4. Scope stayed within shared process execution, Android ADB provider code, and focused tests.
Validation
pnpm exec vitest run src/utils/__tests__/exec-windows-hide.test.ts src/platforms/android/__tests__/adb-executor.test.tspnpm formatpnpm check:quickpnpm test-app:install,pnpm test-app:android,agent-device snapshot -i --platform android --json; verified the Agent Device Tester UI loaded and snapshot returned Android nodes.Known gap:
pnpm check:unitwas attempted. The full suite hit environment/test harness failures unrelated to this change: two failing tests passed when rerun in isolation, andsrc/__tests__/client-metro-packaged.test.tscannot complete in this shell because nonpmbinary is available and its cleanup path kills PID 0 after that setup failure.