refactor: add capture selector command definitions#516
Merged
Conversation
thymikee
force-pushed
the
refactor/capture-selector-command-definitions
branch
from
fc5e8ff to
4efffc5
Compare
|
thymikee
force-pushed
the
refactor/capture-selector-command-definitions
branch
from
4efffc5 to
000f28c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collocate capture command schemas/capabilities for snapshot, diff, and screenshot.
Collocate selector read schemas/capabilities for wait, get, find, and is, and keep selector snapshot flags shared from that family definition.
Follow the #513 command-definition foundation now merged into
main: no commandfamilymetadata, no unused command-name exports, and no tautological definitionsatisfiesblocks.Touched-file count: 8. Scope remains command definition/schema/capability glue;
remote-config-schema.tschanged only to share the Metro option type and keep Fallow duplication clean.Validation
PATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm formatPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm exec vitest run src/commands/interactions/__tests__/definition.test.ts src/utils/__tests__/args.test.ts src/__tests__/command-codecs.test.ts src/core/__tests__/capabilities.test.tsPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm exec fallow audit --changed-since origin/mainPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm check:quick