refactor: split xctestrun product resolution#517
Merged
Conversation
|
thymikee
force-pushed
the
refactor/apple-platform-module-split
branch
from
3570656 to
3daa943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract xctestrun product-reference validation from runner-xctestrun into a focused Apple-family module.
Use the shared project-root resolver from
src/utils/version.ts, and require callers/tests to import product helpers from their owning module directly instead of through a compatibility re-export.Fallow follow-up: flatten product-reference collection and deduplicate repeated runner-client test fixture/env setup.
Touched-file count: 3. Scope stayed within
src/platforms/iosand related iOS tests.Validation
PATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm formatPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm exec fallow audit --changed-since origin/mainPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm exec vitest run src/platforms/ios/__tests__/runner-xctestrun.test.ts src/platforms/ios/__tests__/runner-client.test.tsPATH=/tmp/codex-pnpm/pnpm10-platform/package:/Users/thymikee/.cache/codex-runtimes/codex-primary-runtime/dependencies/node/bin:$PATH pnpm check:quickNotes:
ghis not installed in this local environment, so the Fallow failure was reproduced locally with the PR-scoped audit instead of inspecting Actions logs throughgh.