refactor: add command definition codecs#527
Merged
Merged
Conversation
thymikee
force-pushed
the
refactor/command-definition-codecs
branch
from
9353b69 to
9b363aa
Compare
thymikee
force-pushed
the
refactor/platform-interactors
branch
from
cbd8c70 to
cd67773
Compare
|
thymikee
force-pushed
the
refactor/platform-interactors
branch
from
cd67773 to
92afc80
Compare
thymikee
force-pushed
the
refactor/command-definition-codecs
branch
2 times, most recently
from
194a267 to
d307a2c
Compare
thymikee
force-pushed
the
refactor/platform-interactors
branch
3 times, most recently
from
bf96fab to
572177b
Compare
thymikee
force-pushed
the
refactor/command-definition-codecs
branch
from
d307a2c to
ca6e29e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add staged command-definition codecs and migrate the
typecommand as the first slice.Keeps codec option types on
CommandDefinition, simplifies CLI option merging, and adds coverage for routing through the definition codec path.Validation
pnpm exec vitest run src/commands/__tests__/command-definition.test.tspnpm check:fallow --base 5b1901d8cc2b84a489fea64dc12edd8e7df0cce3pnpm check:quickpnpm check:unit