refactor: split session recording modules#528
Merged
Conversation
thymikee
force-pushed
the
refactor/command-definition-codecs
branch
from
9353b69 to
9b363aa
Compare
thymikee
force-pushed
the
refactor/session-recording-modules
branch
2 times, most recently
from
1e799f9 to
9d4e866
Compare
thymikee
force-pushed
the
refactor/command-definition-codecs
branch
2 times, most recently
from
194a267 to
d307a2c
Compare
thymikee
force-pushed
the
refactor/session-recording-modules
branch
from
9d4e866 to
adbc0e0
Compare
thymikee
force-pushed
the
refactor/command-definition-codecs
branch
from
d307a2c to
ca6e29e
Compare
thymikee
force-pushed
the
refactor/session-recording-modules
branch
from
adbc0e0 to
68085e3
Compare
|
thymikee
force-pushed
the
refactor/session-recording-modules
branch
from
68085e3 to
af7d84c
Compare
thymikee
force-pushed
the
refactor/session-recording-modules
branch
from
af7d84c to
0308c6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split session recording into hot-path recording and export-time script writing modules.
Adds diagnostics for session script write failures/successes and tightens sanitized flag key typing while preserving the existing store facade.
Folded narrow recorder/writer tests into broader
SessionStorecoverage so the test surface follows the handler-facing facade. Cleaned up fallow findings by keeping internal helpers private, reducing repeated store-test setup, and splitting replay script token parsing helpers.Validation
zsh -ilc 'export PNPM_HOME="$HOME/Library/pnpm"; export PATH="$PNPM_HOME:$PATH"; pnpm install --frozen-lockfile'zsh -ilc 'export PNPM_HOME="$HOME/Library/pnpm"; export PATH="$PNPM_HOME:$PATH"; pnpm exec vitest run src/daemon/__tests__/session-store.test.ts src/daemon/handlers/__tests__/replay-heal.test.ts'zsh -ilc 'export PNPM_HOME="$HOME/Library/pnpm"; export PATH="$PNPM_HOME:$PATH"; pnpm check:fallow --base origin/main'zsh -ilc 'export PNPM_HOME="$HOME/Library/pnpm"; export PATH="$PNPM_HOME:$PATH"; pnpm format && pnpm check:quick'zsh -ilc 'export PNPM_HOME="$HOME/Library/pnpm"; export PATH="$PNPM_HOME:$PATH"; pnpm check:unit'