fix: harden iOS simulator recording cleanup#575
Merged
Conversation
|
thymikee
force-pushed
the
codex/ios-recording-cleanup-overlays
branch
4 times, most recently
from
663fb54 to
638c61e
Compare
thymikee
force-pushed
the
codex/ios-recording-cleanup-overlays
branch
from
638c61e to
09d2026
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix iOS simulator recording resilience and cleanup behavior:
record stopnow returns the finalized raw video with anoverlay unavailablewarning when touch overlay telemetry is unusable.simctl recordVideocleanup now prefers the session-owned recorder PID and child PIDs before falling back to path-based matching.Closes #569
Closes #574
Validation
pnpm exec vitest run src/daemon/__tests__/request-recording-health.test.ts src/daemon/__tests__/request-router-recording-health.test.ts src/daemon/handlers/__tests__/record-trace.test.ts src/daemon/__tests__/recording-provider.test.tspnpm exec vitest run src/daemon/__tests__/request-execution-scope.test.tspnpm check:quickpnpm test:smokepassed with 2 loopback-listener smoke tests skipped by the environment.Known gap:
pnpm check:unitstill fails on unrelated environment/tooling-sensitive tests in this worktree: MP4 fallback validation, two iOS status bar mock tests, and one Android bundletool mock test. The initial sandboxed run also hit loopbacklisten EPERMfailures.