fix: internalize XML parsing#606
Merged
Merged
Conversation
thymikee
force-pushed
the
codex/internalize-xml-parser
branch
from
97b7317 to
a68176a
Compare
|
thymikee
force-pushed
the
codex/internalize-xml-parser
branch
from
a68176a to
327a118
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the
fast-xml-parserdependency with a constrained internal XML parser for the existing iOSXmlNodecontract.Add security-oriented parser bounds and regression coverage for entity non-expansion, unsafe attribute names, malformed nesting, document size limits, plist fallback parsing, xctestrun product references, and iOS perf XML parsing.
Remove
fast-xml-parserand its transitive graph frompackage.jsonandpnpm-lock.yaml.Touched files: 4. Scope stayed within the iOS XML parser/dependency surface.
Validation
Verified with
pnpm format, focused iOS XML consumer tests (xml,plist,runner-client,perf: 55 tests),pnpm check:tooling,pnpm test:smoke, dependency reference scan, andnpm pack --dry-runsize check.A full
pnpm check:unitrun was attempted outside the sandbox; it failed only in unrelated Android fill timing tests under full-suite load, and those exact tests passed when rerun in isolation.