fix: apply app icon to iOS UI test runner#611
Merged
Conversation
thymikee
force-pushed
the
fix/ios-runner-uitest-icon
branch
6 times, most recently
from
d82f76e to
f96b518
Compare
thymikee
force-pushed
the
fix/ios-runner-uitest-icon
branch
from
f96b518 to
b29925f
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the synthesized iOS UI test runner app missing its icon by copying compiled app icon artifacts and
CFBundleIconsfromAgentDeviceRunner.appintoAgentDeviceRunnerUITests-Runner.app, then re-signing the runner bundle.Deduplicate the Xcode project down to one
AppIcon.appiconsetand optimize the runner icon/logo assets, reducing theios-runnerpackage-style tar.gz proxy from about 353 KB to 88 KB.Touched-file count: 13. Scope stayed within iOS runner assets/build plumbing.
Validation
Passed
pnpm exec vitest run src/platforms/ios/__tests__/runner-icon.test.ts,pnpm check:fallow --base origin/main,pnpm check:quick, and a fresh iOSbuild-xcuitest-apple.shbuild. The built UI test runner containsAppIcon*.png,Assets.car,CFBundleIcons, and passescodesign --verify --deep --strict.