fix: harden iOS runner command execution#72
Merged
Conversation
|
Contributor
Author
|
Addressed review follow-ups in commit a2bd557:\n- confirmed both execute paths use executeOnMainSafely (main-thread + dispatched path)\n- centralized NSError domains/codes in RunnerTests for stable semantics\n- added explicit timeout behavior comment (main queue work may still run after timeout)\n- added NSException name fallback in Obj-C catcher to avoid null prefixes\n\nValidation rerun: pnpm build:xcuitest (TEST BUILD SUCCEEDED). |
thymikee
force-pushed
the
codex/ios-runner-hardening
branch
from
0d07d9c to
8fde634
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardened the iOS XCUITest runner command path so transient app instability no longer crashes or restarts the runner during interactions.
continueAfterFailure = true)NSExceptionis surfaced as recoverable command errorstap,longPress,drag) on transient failuresValidation
pnpm build:xcuitestpnpm ad open --platform ios RNCLI83pnpm ad snapshot -i --platform iospnpm ad click @e5 --platform iossnapshot -> click(no command failures)~/.agent-device/daemon.logfor run window (noRestarting after unexpected exit/** TEST EXECUTE FAILED **markers)