Skip to content

Conversation

@grabbou
Copy link
Contributor

@grabbou grabbou commented Sep 30, 2025

This is working, but performance of MLC on Android is questionable and subject to further optimization. On top of that, top_k and aborting a stream are not supported (will require a follow-up PR to the engine itself).

Generally speaking, it all works just fine, but there's UI freeze first time you run the model, likely related to mlc-ai/mlc-llm#1401 (comment)

I have updated parameters on Android to make them slightly more user-friendly and generally cleaned-up models configuration.

Closes #118

Notable changes in the PR:

  • fixed Gradle sync working
  • removed support for old architecture
  • proper references to precompiled MLC runtime (made in previous PR already)
  • reworked and simplified model downloading
  • added progress tracking (updated iOS as well)

@cursor
Copy link

cursor bot commented Sep 30, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 2.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@vercel
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ai Ready Ready Preview Comment Oct 13, 2025 2:05pm

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@grabbou
Copy link
Contributor Author

grabbou commented Oct 10, 2025

Update: Seems to be working, but need to get real device tomorrow to check! 😂

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@callstackincubator callstackincubator deleted a comment from cursor bot Oct 13, 2025
@callstackincubator callstackincubator deleted a comment from cursor bot Oct 13, 2025
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@grabbou
Copy link
Contributor Author

grabbou commented Oct 14, 2025

For the lack of objection, I am going to shamelessly merge this PR and move on with other features! Hopefully we can unlock some MLC issues in the meantime. Meanwhile, I'll work on some other interesting features!

@grabbou grabbou merged commit f145812 into main Oct 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: refactor and bring Android MLC back to life

3 participants