fix(android): add missing badgeBackgroundColor and badgeTextColor to TabInfo #482
+12
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TabInfo The TabInfo data class was missing badgeBackgroundColor and badgeTextColor properties that RCTTabView.kt expects when applying badge colors. This caused Android builds to fail with: - Unresolved reference 'badgeBackgroundColor' - Unresolved reference 'badgeTextColor' - Unresolved reference 'colorError' Changes: - Add badgeBackgroundColor and badgeTextColor properties to TabInfo data class - Populate them from JS bridge in setItems() - Simplify badge color application to let Material use default theme colors when custom colors are not provided (avoids colorError resolution issues) Fixes callstackincubator#481
🦋 Changeset detectedLatest commit: 3e269c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Thank you! This error wasn't appearing for me on build |
okwasniewski
approved these changes
Dec 3, 2025
Collaborator
okwasniewski
left a comment
okwasniewski
left a comment
There was a problem hiding this comment.
Thanks for fixing it!
Collaborator
Yeah.. weird it wasn't caught by the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #481
The
TabInfodata class was missingbadgeBackgroundColorandbadgeTextColorproperties thatRCTTabView.ktexpects when applying badge colors.This caused Android builds to fail with:
Changes
badgeBackgroundColorandbadgeTextColorproperties toTabInfodata classsetItems()colorErrorresolution issues with some Material library versions)Test Plan