Skip to content

Breaking Plist by carefully picking library name #126

@mani3xis

Description

@mani3xis

There is a possibility to pick a library name (user-provided input) in such a way, that the oldLibraryName will end up as any Plist specific keyword or tag. All instances of such a name will be replaced by replaceAll() function, yielding the Plist file invalid.

https://github.com/callstackincubator/react-native-node-api/blame/3de8033a96a1710e182ead9b318038cf3cf55edc/packages/host/src/node/cli/apple.ts#L31-L33

It is highly advised to update this code so that it only updates values (and ideally carefully selected keys by path) than doing a potentially dangerous shotgun approach.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Apple 🍎Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.)good first issueGood for newcomers

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions