Convert binary plist files to xml and use a proper parser when linking

[kraenhansen]

Fixes #126 by using a proper plist parser (@expo/plist) and also handles converting binary plists to xml before updating.

[Copilot]

Pull Request Overview

This PR replaces manual plist string manipulation with the @expo/plist parser library and adds support for converting binary plist files to XML format before modification. This addresses issue #126 by providing proper plist parsing and handling of binary plist formats.

Key changes:

• Replaced custom createPlistContent() with @expo/plist library's build() method
• Modified readInfoPlist() to accept a file path parameter and use plist.parse() instead of returning raw string contents
• Added binary-to-XML conversion step in updateInfoPlist() using the plutil command-line tool

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File	Description
packages/host/package.json	Added @expo/plist dependency
packages/host/src/node/prebuilds/apple.ts	Replaced custom plist generation with @expo/plist library
packages/host/src/node/cli/apple.ts	Refactored plist reading/updating to use proper parser and handle binary format conversion
packages/host/src/node/cli/apple.test.ts	Updated tests to reflect API changes and added binary plist conversion test

[Copilot]

The plutil conversion command will silently succeed even if the file is already in XML format, but if it fails (e.g., corrupted file, invalid plist), the error won't be captured effectively with outputMode: "inherit". Consider adding error handling or validation after the conversion to ensure the plist is in a valid state before attempting to parse it.

Suggested change

	// Convert to XML format if needed
	await spawn("plutil", ["-convert", "xml1", infoPlistPath], {
	outputMode: "inherit",
	});
	const contents = await readInfoPlist(infoPlistPath);
	// Convert to XML format if needed, and validate conversion
	try {
	await spawn("plutil", ["-convert", "xml1", infoPlistPath], {
	outputMode: "inherit",
	});
	} catch (plutilError) {
	throw new Error(`Failed to convert Info.plist to XML format at "${infoPlistPath}".`, { cause: plutilError });
	}
	let contents: Record<string, unknown>;
	try {
	contents = await readInfoPlist(infoPlistPath);
	} catch (parseError) {
	throw new Error(`Info.plist at "${infoPlistPath}" is not a valid plist after conversion.`, { cause: parseError });
	}

[Copilot]

The conditional check prevents updating if CFBundleExecutable doesn't match oldLibraryName, but this silently skips the update without any indication. Consider logging a warning or throwing an error if the expected value doesn't match, as this could indicate an unexpected plist state or incorrect parameters.

Suggested change

	contents.CFBundleExecutable = newLibraryName;
	contents.CFBundleExecutable = newLibraryName;
	} else {
	throw new Error(
	`CFBundleExecutable in Info.plist at "${infoPlistPath}" is "${contents.CFBundleExecutable}", expected "${oldLibraryName}". Aborting update.`
	);

[Copilot]

The base64-encoded binary plist lacks documentation explaining what it represents or how it was generated. Add a comment describing the plist's content (e.g., 'Binary plist containing CFBundleExecutable: "addon"') and how to regenerate it if needed, to improve test maintainability.