Skip to content

Escape the crate name when transforming it into a bundle identifier #313

@kraenhansen

Description

@kraenhansen

We shouldn't allow underscores in the bundle CFBundleIdentifier of the frameworks produced by Ferric.

The alternative is errors when building the app:

/Users/bebra/Library/Developer/Xcode/DerivedData/expopshenmicdpptest-gxbbwnlbvquuvrfweiofzukcpmxr/Build/Products/Debug-iphonesimulator/expopshenmicdpptest.app/Frameworks/pshenmic-dpp-napi--pshenmic_dpp_napi.framework had an invalid CFBundleIdentifier in its Info.plist: com.callstackincubator.node-api.libpshenmic_dpp_napi (in target 'expopshenmicdpptest' from project 'expopshenmicdpptest')  

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions