Skip to content

Warn on "pod install" with the new architecture disabled #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2025
Merged

Warn on "pod install" with the new architecture disabled #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wicked-tables-deny.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-node-api": patch
---

Warn on "pod install" with the new architecture disabled
4 changes: 4 additions & 0 deletions packages/host/react-native-node-api.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ unless defined?(@xcframeworks_copied)
@xcframeworks_copied = true
end

if ENV['RCT_NEW_ARCH_ENABLED'] == '0'
Pod::UI.warn "React Native Node-API doesn't support the legacy architecture (but RCT_NEW_ARCH_ENABLED == '0')"
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The warning message could be clearer about the required action. Consider rephrasing to: 'React Native Node-API requires the new architecture. Please set RCT_NEW_ARCH_ENABLED=1 in your project configuration.'

Suggested change
Pod::UI.warn "React Native Node-API doesn't support the legacy architecture (but RCT_NEW_ARCH_ENABLED == '0')"
Pod::UI.warn "React Native Node-API requires the new architecture. Please set RCT_NEW_ARCH_ENABLED=1 in your project configuration."

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

@kraenhansen kraenhansen Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specifically wanted to use the "legacy architecture" in the naming, here - since the new architecture is now the default architecture.

end

Pod::Spec.new do |s|
s.name = package["name"]
s.version = package["version"]
Expand Down
Loading