Skip to content

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Nov 2, 2025

Merging this PR will:

  • Rename the ios directory to apple as this code is generally applicable across Apple platforms, beyond iOS.
  • Simplify the implementation to take advantage of the fact that we're supporting a very limited set of React Native versions, all of which have the ReactCommon/CxxTurboModuleUtils.h API available.

Note

Moves iOS host code to apple and simplifies the TurboModule provider to unconditionally use CxxTurboModuleUtils with +load registration.

  • Apple host:
    • Move packages/host/ios to packages/host/apple; update podspec s.source_files to point to apple/**/*.
    • Simplify TurboModule provider:
      • Add packages/host/apple/NodeApiHostModuleProvider.mm using ReactCommon/CxxTurboModuleUtils.h and +load to register via registerCxxModuleToGlobalModuleMap.
      • Remove legacy conditional paths and bridge-based RCTTurboModule code from packages/host/ios/NodeApiHostModuleProvider.mm.
  • Release:
    • Add changeset to publish a patch for react-native-node-api.

Written by Cursor Bugbot for commit 328d75c. This will update automatically on new commits. Configure here.

@kraenhansen kraenhansen self-assigned this Nov 2, 2025
@kraenhansen kraenhansen added Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Host 🏡 Our `react-native-node-api-modules` package labels Nov 2, 2025
@kraenhansen kraenhansen merged commit c698698 into main Nov 2, 2025
8 checks passed
@kraenhansen kraenhansen deleted the kh/apple-host-turbomodule branch November 2, 2025 12:55
kraenhansen added a commit that referenced this pull request Nov 5, 2025
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) Host 🏡 Our `react-native-node-api-modules` package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants