Moved patching of JSI headers to a separate function #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
Apple 🍎
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JSI header patching logic in the Hermes vendoring command by extracting it into a dedicated function. The change improves code organization and makes the patching logic reusable, even though the immediate need for multiple calls has been resolved.
Key changes:
- Extracted JSI header copying logic into a new
patchJsiHeaders()function - Introduced
PatchJSIHeadersOptionstype for type-safe parameter passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging this PR will:
Resulting from a need to call this more than once, which went away - but I'd like to hang onto this refactor to keep things more aligned with the semantics 👍